Skip to content

Convert Date/Time/DateTime form fields to appropriate Graphene types #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2018

Conversation

sciyoshi
Copy link
Contributor

@sciyoshi sciyoshi commented Jan 8, 2018

No description provided.

@coveralls
Copy link

coveralls commented Jan 8, 2018

Coverage Status

Coverage increased (+0.05%) to 93.621% when pulling bb2d24e on sciyoshi:convert-date-time into 53546a2 on graphql-python:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 93.191% when pulling 2e3a341 on sciyoshi:convert-date-time into b54e02c on graphql-python:master.

@patrick91
Copy link
Member

I've rebased from master and this is ready to be merged! /cc @syrusakbary

@urbandove
Copy link
Contributor

The graphene type Date was only added in graphene 2.0.1 - so before this gets merged it needs to make graphene-django have a requirement of graphene >= 2.0.1

In my pull request #335 I've updated that dependancy - so maybe the 2 pull request should be merged together?

@syrusakbary syrusakbary merged commit 94ee970 into graphql-python:master Feb 8, 2018
@urbandove urbandove mentioned this pull request Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants